jenkins-x / lighthouse

Apache License 2.0
184 stars 115 forks source link

The default value of GIT_SERVER is "github.com" even if GIT_KIND isn't "github" #1581

Open monaka opened 1 year ago

monaka commented 1 year ago

Referring to the description in README.md,

GIT_SERVER : the URL of the server if not using the public hosted git providers:

So the default value of GIT_SERVER should be https://gitlab.com if they set gitlab as GIT_KIND. But it looks that the default value of GIT_SERVER is always https://github.com.

It can be avoided by setting GIT_SERVER='https://gitlab.com' explicitly.

msvticket commented 1 week ago

It seems like this is a feature request. Do rewrite the title and description as such.