feat: allow to skip draft prs unless ready for review or /ok-to-test is added

JordanGoasdoue commented 7 months ago

:warning: Once this PR merged we will need to

wait for lighthouse-client update
update this jx-gitops PR: https://github.com/jenkins-x-plugins/jx-gitops/pull/956

Context:

We can't add label when opening a PR so we can only Draft a PR to disable the trigger of pipelines in case we need massive batch opening of PRs in 100+ repositories for instance .
Then we can activate manually the pipelines by clicking on 'Ready for Review' or commenting /ok-to-test from a trusted member

How to enable this feature ? Add skip_draft_pr feature on the Trigger Plug-in from you scheduler:

setup skip_draft_pr in scheduler trigger like only_org_members to allow easy migration of multiple team-app repositories in one time (Would be automatically applied to all repositories using the scheduler with this trigger.skip_draft_pr set to true)
jx gitops scheduler would need to be run then from your bootjob to edit the plugin configmap

How it works ?

trigger pipelines in a Draft PR if skip_draft_pr is false depending if trusted or not (by default)
trigger pipelines in a Draft PR if skip_draft_pr is true with ok-to-test label
doesn't trigger pipelines in a Draft PR if skip_draft_pr is true but without ok-to-test label
trigger pipelines when you click on ready for review if trusted and you don't have the ok-to-test label to avoid triggering the same pipelines than in previous draft mode before clicking the ready for review button
doesn't trigger pipelines when you click on convert to draft even if you have the ok-to-test label to avoid triggering the same pipelines than in previous non draft mode before clicking the convert to draft button

Why this feature ?

keep costs low when developers don't want to run builds
Interesting when we need to open multiple Draft PRs in repositories using Jx without wanting to trigger all the repositories pipelines in same time

:point_down: :point_down: :point_down: :point_down: I have commented each testing scenarios in pkg/plugins/trigger/pull-request_test.go with the following PR Actions:

prAction: scm.ActionReadyForReview
prAction: scm.ActionConvertedToDraft

to explain the logic behind when we click the "Ready for Review" or "Convert to Draft" button. I wanted here to avoid useless rerun of pipelines between both these modes.

go test ./pkg/plugins/trigger/ 
ok      github.com/jenkins-x/lighthouse/pkg/plugins/trigger     0.028s

:point_up: :point_up: :point_up: :point_up:

jenkins-x-bot commented 7 months ago

Hi @JordanGoasdoue. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.

tomhobson commented 7 months ago

/ok-to-test /lgtm

Thanks for the PR!

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

Failed to merge this PR due to:

jenkins-x-bot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x/lighthouse/blob/main/OWNERS)~~ [tomhobson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

jenkins-x / lighthouse

feat: allow to skip draft prs unless ready for review or /ok-to-test is added #1593