jenkins-x / lighthouse

Apache License 2.0
183 stars 114 forks source link

chore: allows use of tekton pipelineRef.Resolver #1599

Closed JordanGoasdoue closed 5 months ago

JordanGoasdoue commented 5 months ago

allows us to use the native tekton pipelineRef git resolver

  pipelineRef:
    resolver: git
    params:
      - name: repo
        value: xxx
      - name: revision
        value: main
      - name: pathInRepo
        value: /path/to/pipeline.yaml

in such case, our pipelineRef.name is empty, but it's not an error

jenkins-x-bot commented 5 months ago

Hi @JordanGoasdoue. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
jenkins-x-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x/lighthouse/blob/main/OWNERS)~~ [tomhobson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
msvticket commented 5 months ago

/ok-to-test