search

jenkins-x / lighthouse

Apache License 2.0
183 stars 114 forks source link

feat: allow to list trusted apps #1603

Closed Maximilien-R closed 4 months ago

Maximilien-R commented 4 months ago

Currently, the way Lighthouse work doesn't allow us to automatically trigger PRs pipelines when the PR is created by a Github App.

This behaviour is related to the fact that Lighthouse trigger pipelines only for trusted PRs authors. Trusted authors being either the collaborators of the repository or the members of the organization. However, Github apps can't be in any of these cases.

In order to allow Github Apps to be considered as trusted authors, I suggest adding a new configuration option for the Trigger plugin to list authorized applications.

Note: this is a copy of the implementation made in prow.

jenkins-x-bot commented 4 months ago

Hi @Maximilien-R. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
msvticket commented 4 months ago

/ok-to-test

msvticket commented 4 months ago

/approve

jenkins-x-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x/lighthouse/blob/main/OWNERS)~~ [msvticket] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment