search

jenkins-x / lighthouse

Apache License 2.0
184 stars 115 forks source link

feat: allow skipping report comments #1611

Closed Maximilien-R closed 5 months ago

Maximilien-R commented 5 months ago

This PR is intended to allow you to pass the reporting process done in the Forghon controller while keeping the SCM status.

The need behind this feature is to limit calls to SCM API and avoid rate limiting issues.

jenkins-x-bot commented 5 months ago

Hi @Maximilien-R. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
JordanGoasdoue commented 5 months ago

/ok-to-test

jenkins-x-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JordanGoasdoue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x/lighthouse/blob/main/OWNERS)~~ [JordanGoasdoue] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment