search

jenkins-x / lighthouse

Apache License 2.0
185 stars 115 forks source link

fix: base ref #1618

Closed msvticket closed 6 days ago

msvticket commented 1 week ago

The baseRefOID field is used as the sha of the base ref. The problem is that the returned value for this field sometimes is another sha. Often I think it is the sha of the base when the PR was created, but sometimes it is the sha of a much older commit.

In this PR I replace the use of baseRefIOD with 

baseRef {
    target {
        oid
    }
}

This seems to always be the current sha of the base ref, which is what we want.

This should fix the issue reported here: https://kubernetes.slack.com/archives/C9MBGQJRH/p1728050746717079

jenkins-x-bot commented 1 week ago

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated. We'll continue to update you through PRs as we progress. Please check #8589 for further information.

jenkins-x-bot commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skisocks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x/lighthouse/blob/main/OWNERS)~~ [Skisocks] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment