search

jenkins-x / terraform-aws-eks-jx

A Terraform module for creating Jenkins X infrastructure on AWS
Apache License 2.0
63 stars 43 forks source link

Update main.tf #110

Closed himanso closed 4 years ago

himanso commented 4 years ago

the command was unable to find the cluster without the region parameter. With region parameter it is working fine

aws eks update-kubeconfig --name ${var.cluster_name} --region ${var.region}

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

jenkins-x-bot commented 4 years ago

Hi @himanso. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
jenkins-x-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign dgozalo You can assign the PR to them by writing /assign @dgozalo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jenkins-x/terraform-aws-eks-jx/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ankitm123 commented 4 years ago

Going to close this PR @himanso as #102 fixes the doc issue.

ankitm123 commented 4 years ago

/close

jenkins-x-bot commented 4 years ago

@ankitm123: Closed this PR.

In response to [this](https://github.com/jenkins-x/terraform-aws-eks-jx/pull/110#issuecomment-663604927): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.