search

jenkins-x / terraform-aws-eks-jx

A Terraform module for creating Jenkins X infrastructure on AWS
Apache License 2.0
63 stars 43 forks source link

Conditional creation #186

Closed naliwajek closed 4 years ago

naliwajek commented 4 years ago

Summary

Hi.

What do you think about adding conditional creation?

It helps when you have many workspaces using same code and you just want to pass configuration variables to enable or disable parts of your environment.

See example here.

Would it be OK with you to add it to this repo? I can try to make a PR if yes 😄

(Or perhaps I can't read and it's already implemented under some argument 🙈 )

Cheers.

ankitm123 commented 4 years ago

@naliwajek This is a valid request, and there is another issue abt it: #67, which I am working on currently. I should have it done soonish.

pparth commented 4 years ago

generally, we should have the ability to parameterize these Terraform scripts fully. E.g. in our case, we already have an EKS cluster, an ECR, a Vault installation and others.

ankitm123 commented 4 years ago

generally, we should have the ability to parameterize these Terraform scripts fully. E.g. in our case, we already have an EKS cluster, an ECR, a Vault installation and others.

That is what I am working towards, as it's a requirement.

ankitm123 commented 4 years ago

:tada: This issue has been resolved in version 1.10.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: