search

jenkins-x / terraform-aws-eks-jx

A Terraform module for creating Jenkins X infrastructure on AWS
Apache License 2.0
63 stars 43 forks source link

fix: fixed deprecate #190

Closed dtherhtun closed 3 years ago

dtherhtun commented 3 years ago

Description

Just edit the old Terraform variable style that was deprecated at the submodule cluster. remove the "${ sequence from the start and the }"

Special notes for the reviewer(s)

Which issue this PR fixes

Warning: Interpolation-only expressions are deprecated fixes: #190

jenkins-x-bot commented 3 years ago

Hi @DTherHtun. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
dtherhtun commented 3 years ago

/assign @ankitm123

ankitm123 commented 3 years ago

@DTherHtun can you fix the commit message? 

git commit --amend -m "fix: fixed deprecate"
git push -f origin fix-deprecate
ankitm123 commented 3 years ago

/ok-to-test

ankitm123 commented 3 years ago

/lgtm

jenkins-x-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitm123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com#issuecomment-720503124/jenkins-x/terraform-aws-eks-jx/blob/master/OWNERS)~~ [ankitm123] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ankitm123 commented 3 years ago

:tada: This PR is included in version 1.10.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: