search

jenkins-x / terraform-aws-eks-jx

A Terraform module for creating Jenkins X infrastructure on AWS
Apache License 2.0
63 stars 43 forks source link

fix: do not provision worker group launch templates for eks managed node group #193

Closed ankitm123 closed 3 years ago

ankitm123 commented 3 years ago

Signed-off-by: ankitm123 ankitmohapatra123@gmail.com

Which issue this PR fixes

fixes #192

ankitm123 commented 3 years ago

/assign @jstrachan

jstrachan commented 3 years ago

/lgtm

jenkins-x-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com#issuecomment-721400650/jenkins-x/terraform-aws-eks-jx/blob/master/OWNERS)~~ [jstrachan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ankitm123 commented 3 years ago

:tada: This PR is included in version 1.10.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: