search

jenkins-x / terraform-aws-eks-jx

A Terraform module for creating Jenkins X infrastructure on AWS
Apache License 2.0
63 stars 43 forks source link

fix: add object access to visualizer policy #222

Closed KaKeimei closed 3 years ago

KaKeimei commented 3 years ago

Give not only bucket access but also object access to the visualizer, or it will get no access to the logs:

status code: 403, request id: 6301D24E45EF1903, host id: Lqtrx39JLM289tl7UODgB2z3V53nGuxv7kLVNQse8qw7ZqmBfh/JIogNBcWGOuAyaj4dE83Fwpk=

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

jenkins-x-bot commented 3 years ago

Hi @KaKeimei. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
jenkins-x-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign garethjevans You can assign the PR to them by writing /assign @garethjevans in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jenkins-x/terraform-aws-eks-jx/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
KaKeimei commented 3 years ago

/assign @garethjevans

ankitm123 commented 3 years ago

@KaKeimei can you fix the PR title and commit to follow the semantic convention? Nice catch btw. Something like this will work: fix: add object access to visualizer policy

KaKeimei commented 3 years ago

@KaKeimei can you fix the PR title and commit to follow the semantic convention? Nice catch btw. Something like this will work: fix: add object access to visualizer policy

OK, I'll close this one and create a new PR that follows semantic convention

KaKeimei commented 3 years ago

https://github.com/jenkins-x/terraform-aws-eks-jx/pull/225