Closed gmaiztegi closed 3 years ago
Hi @gmaiztegi. Thanks for your PR.
I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign marckk
You can assign the PR to them by writing /assign @marckk
in a comment when ready.
The full list of commands accepted by this bot can be found here.
/ok-to-test
@gmaiztegi can you change the commit message to fix: pass through the create_<app>_role variables
? I changed the PR title.
Description
The
create_<app>_role
are not really passed to the cluster submodule, so the roles are always created regardless of what the user sets in these parameters. This PR tries tof fix this.