jenkins-x / terraform-aws-eks-jx

A Terraform module for creating Jenkins X infrastructure on AWS
Apache License 2.0
63 stars 42 forks source link

feat: tag subnets manually if not creating vpc #282

Closed dali546 closed 10 months ago

dali546 commented 3 years ago

Description

a cluster with version 1.19+ no longer creates subnet tags automatically.

And also when not creating a VPC, we still need to tag the subnets as public or private

This commit adds the relavant tags.

Source: https://docs.aws.amazon.com/eks/latest/userguide/network_reqs.html#vpc-subnet-tagging and also https://docs.aws.amazon.com/eks/latest/userguide/alb-ingress.html