search

jenkins-x / terraform-aws-eks-jx

A Terraform module for creating Jenkins X infrastructure on AWS
Apache License 2.0
63 stars 42 forks source link

fix: change secrets manager name in requirements file #295

Closed babadofar closed 3 years ago

babadofar commented 3 years ago

Terraform sets the name of the secretStorage to "asm", which is not recognised in the gitops operator, who expects the name "secretsManager". The current setup makes the default configuration the only configuration you ever can get. Which makes it really hard to change things.

babadofar commented 3 years ago

Yes Sorry, should perhaps not mix these two issues in one PR. I will remove the irsa.tf file from this PR

ankitm123 commented 3 years ago

The semantic PR check is failing, you can change the PR title to fix: change secrets manager name in requirements file