search

jenkins-x / terraform-aws-eks-jx

A Terraform module for creating Jenkins X infrastructure on AWS
Apache License 2.0
63 stars 42 forks source link

Support supplying values to git-operator chart #303

Closed msvticket closed 2 years ago

msvticket commented 3 years ago

Summary

It would be good if you could supply values to the git-operator chart.

My use case is that I need to supply the annotation eks.amazonaws.com/role-arn to sa jx-boot-job.

ankitm123 commented 3 years ago

I think the simplest solution would be to do what we do for the nginx helm chart, and provide values.yaml file. See: https://github.com/jenkins-x/terraform-aws-eks-jx/blob/master/modules/nginx/main.tf#L9

msvticket commented 3 years ago

I looked at the nginx model and I don't think that is a good idea, because that means that the user needs to supply all values.

ankitm123 commented 3 years ago

I think that is more flexible, else we have 100 different use cases and then it becomes hard to make everyone happy :grimacing: . You can just give them a few values as template, and let them add more ...

user needs to supply all values.

You can also do a hybrid approach - set some common values using set and then also give users the ability to use values.yaml. Also it's best to stick to native helm approach imo ...