search

jenkins-x / terraform-aws-eks-jx

A Terraform module for creating Jenkins X infrastructure on AWS
Apache License 2.0
63 stars 42 forks source link

S3 bucket still created when storage is disabled #321

Closed msvticket closed 2 years ago

msvticket commented 2 years ago

Summary

If a storage is disabled by setting either of enable_logs_storage, enable_reports_storage or enable_repository_storage to false the bucket is still created, it just doesn't turn up in jx-requirements.yaml.

Steps to reproduce the behavior

Create cluster with terraform configuration where a fragment looks like:

module "eks-jx" {
    source                         = "github.com/jenkins-x/terraform-aws-eks-jx?ref=v1.17.2"
    cluster_name                   = "test"
    enable_reports_storage         = false

Expected behavior

No bucket with prefix reports-test- is created.

Actual behavior

Bucket with prefix reports-test- is created.

Module version

1.17.2