search

jenkins-x / terraform-aws-eks-jx

A Terraform module for creating Jenkins X infrastructure on AWS
Apache License 2.0
63 stars 41 forks source link

feat: upgrade aws tf provider to 4 #352

Closed ankitm123 closed 2 years ago

ankitm123 commented 2 years ago

Signed-off-by: ankitm123 ankitmohapatra123@gmail.com

Description

Upgrade tf provider to 4.0+ and remove all deprecations in the module because of the upgrade.

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #339

Release notes

ankitm123 commented 2 years ago

Works in my test cluster, without any issues, but would be good to have a few testers.

Tested in my cluster using (comment out source and version in ur main.tf):

source                           = "github.com/ankitm123/terraform-aws-eks-jx?ref=ankitm123.tf-aws-4"

Run:

In my cluster this is what I get:

Plan: 8 to add, 1 to change, 1 to destroy.

The destroy is unrelated to these changes.

babadofar commented 2 years ago

Confirm that this works, on my cluster which has not been updated since version 1.15 /approve