search

jenkins-x / terraform-aws-eks-jx

A Terraform module for creating Jenkins X infrastructure on AWS
Apache License 2.0
63 stars 41 forks source link

feat: disable kuberhealthy installation by default #355

Closed ankitm123 closed 1 year ago

ankitm123 commented 1 year ago

Signed-off-by: ankitm123 ankitmohapatra123@gmail.com

Description

Kuberhealthy is anyways not working since 1.22 and causes lot of issues for new users. Disabling it by default makes sense IMO. Also it's not core jx.

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

Release notes

msvticket commented 1 year ago

Well, I am running kuberhealthy in 1.22. The default checks are working, but not the jx ones. So it makes sense to me to disable by default.

jx health status -A is still run by the boot job. Running that in a cluster without kuberhealthy gives:

kuberhealthy is not running in namespace kuberhealthy with deployment kuberhealthy
for help on installing kuberhealthy see: https://jenkins-x.io/v3/admin/setup/health#install

This is fine in principle, but the link should then contain correct instructions for installation, so please fix that.

/approve