jenkins-x / terraform-aws-eks-jx

A Terraform module for creating Jenkins X infrastructure on AWS
Apache License 2.0
63 stars 41 forks source link

feat: Allow specifying boot_iam_role #356

Closed msvticket closed 1 year ago

msvticket commented 1 year ago

Unless you set use_asm it was previously not possible to set boot_iam_role. You couldn't add it with

boot_secrets                    = [
    {
        name  = "bootServiceAccount.annotations.eks\\.amazonaws\\.com/role-arn"
        value = "arn:aws:iam::${var.aws_account}:role/jx-boot-job"
        type  = "string"
    }
]

either, since it would be overwritten with an empty value,

Since the role can be used for other things than asm I added a new input to make that clear.

ankitm123 commented 1 year ago

Just need to run make docs, and update read me, then merge it ...