search

jenkins-x / terraform-google-jx

A Terraform module for creating Jenkins X infrastructure on Google Cloud
Apache License 2.0
38 stars 96 forks source link

chore: update terraform-docs to in-place update README #192

Closed khos2ow closed 8 months ago

khos2ow commented 3 years ago

terraform-docs v0.12 added support for --output-file which can be used alongside --output-mode inject to in-place update the content inside a target file (e.g. README.md).

This also adds '.terraform-docs.yml' file for better user experience and consistency across team members.

jenkins-x-bot-test commented 3 years ago

Hi @khos2ow. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
jenkins-x-bot-test commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign cagiti You can assign the PR to them by writing /assign @cagiti in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jenkins-x/terraform-google-jx/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
khos2ow commented 3 years ago

/assign @cagiti

khos2ow commented 3 years ago

@jstrachan bot said to ping Cai but maybe you can take a look at this too?

khos2ow commented 3 years ago

/assign @jstrachan /unassign @cagiti

msvticket commented 8 months ago

I've rebased on master and run make markdown-table to resolve conflict

/ok-to-test

msvticket commented 8 months ago

/approve

jenkins-x-bot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x/terraform-google-jx/blob/master/OWNERS)~~ [msvticket] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment