search

jenkins-x / terraform-google-jx

A Terraform module for creating Jenkins X infrastructure on Google Cloud
Apache License 2.0
38 stars 95 forks source link

dns modue fails when domain starts with a number #199

Open sumerion opened 3 years ago

sumerion commented 3 years ago

Hi,

There is a naming convention in the DNS module that fails if the apex domain starts with a number. Google DNS does not allow the zone name to begin with a number.

Maybe there could be a variable that allows for the zone name to be overridden or add a prefix to the naming convention, e.g., root-.

https://github.com/jenkins-x/terraform-google-jx/blob/master/modules/dns/main.tf managed_zone = replace(var.apex_domain, ".", "-")

Kind regards, Kris.

sumerion commented 3 years ago

workaround possible with using apex_domain_integration_enabled: false ns recordset in the apex_domain zone needs to be created manually