search

jenkins-x / terraform-google-jx

A Terraform module for creating Jenkins X infrastructure on Google Cloud
Apache License 2.0
38 stars 96 forks source link

Added option to opt out of primary nodepool #232

Closed mmn0o7 closed 1 year ago

mmn0o7 commented 1 year ago

Added option to opt out of primary node pool, so that you can deploy your own node pool with custom configuration

jenkins-x-bot commented 1 year ago

Hi @mmn0o7. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
msvticket commented 1 year ago

/ok-to-test

msvticket commented 1 year ago

/approve

jenkins-x-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x/terraform-google-jx/blob/master/OWNERS)~~ [msvticket] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment