search

jenkinsci / acceptance-test-harness

Acceptance tests cases for Jenkins and its plugins based on selenium and docker.
128 stars 234 forks source link

chore(pipeline) Limit Docker API rate limit when testing #1640

Closed dduportal closed 3 months ago

dduportal commented 3 months ago

fixup of #1634 (b1e9d055)

This PR uses the DockerHub authentication in the proper location as pointed out by @basil in https://github.com/jenkinsci/acceptance-test-harness/pull/1634#pullrequestreview-2200077460 (sorry for the noise)

The DockerHub login now happens at the beginning of each test:

Capture d’écran 2024-07-26 à 16 49 53

Note: the long term solution would be to use a local Docker cache-through proxy as per https://github.com/jenkins-infra/helpdesk/issues/4192#issuecomment-2250887939.

basil commented 3 months ago

Fix seems to have failed, as https://ci.jenkins.io/job/Core/job/acceptance-test-harness/job/PR-1645/1/ failed with a rate limit error.

dduportal commented 3 months ago

Fix seems to have failed, as https://ci.jenkins.io/job/Core/job/acceptance-test-harness/job/PR-1645/1/ failed with a rate limit error.

Reopening https://github.com/jenkins-infra/helpdesk/issues/4192

@basil I'm not sure about the error (I might be misusing the Test reports!) but I only see test errors reporting Failed to build image (1): 23e678bc2c56 . But I cannot find any line related to HTTP/429, 429, Too many or rate keywords (also checked in https://ci.jenkins.io/job/Core/job/acceptance-test-harness/job/PR-1645/1/consoleText. What did I missed in the report?