search

jenkinsci / additional-identities-plugin

Additional Identities Plugin
https://plugins.jenkins.io/additional-identities-plugin
MIT License
4 stars 10 forks source link

Modernize plugin #5

Closed viceice closed 8 months ago

viceice commented 11 months ago

Modernize plugin to compile with java 17 / 21

Testing done

Just compile with java 17 / 21 and uploaded to jenkins

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue
viceice commented 8 months ago

@jglick Any chance to review this?

jglick commented 8 months ago

I am not a maintainer; probably there is none. Adopt it if you want.

viceice commented 8 months ago

OK will do that.

btw: you are set as developer 🙃

https://github.com/jenkins-infra/repository-permissions-updater/blob/9b3269169b18ead04b20dd27a3ec541b8f458c88/permissions/plugin-additional-identities-plugin.yml#L9

jglick commented 8 months ago

That may be for historical reasons. I do not in fact have write access to the repository.

jglick commented 8 months ago

(https://github.com/jenkins-infra/repository-permissions-updater/commit/a67361937ced805d4873b3637df278e2d65effc5, perhaps based on https://github.com/jenkinsci/additional-identities-plugin/commit/451b411c48076b201b8c353c454b024f7a9ca0e8, my sole “contribution”.)

viceice commented 8 months ago

ok, will open adoption Pr tomorrow 🤗

viceice commented 8 months ago

🤗