search

jenkinsci / amazon-ecs-plugin

Amazon EC2 Container Service Plugin for Jenkins
https://plugins.jenkins.io/amazon-ecs
MIT License
193 stars 227 forks source link

Allow setting worker agent container name in multi-container task definition #266

Closed nlucero closed 1 year ago

nlucero commented 2 years ago

What feature do you want to see added?

I'm currently using this plugin with a custom task definition for the worker agents and facing some difficulties around the order of the containers definitions. This plugin assumes the first container is the one running the Jenkins worker agent (see here) but for some reason, my task definition (which gets generated form a CloudFormation template) doesn't honor the order of containers I'm setting there, which is making the plugin running an unrelated container as the agent one and causing issues.

It would be great if instead of relying on the order of the containers in the task definition, we could set the name of the container running the Jenkins worker agent in the plugin configuration.

Upstream changes

No response

Stericson commented 1 year ago

This will be in the next release. Thanks for the PR!