jenkinsci / amazon-ecs-plugin

Amazon EC2 Container Service Plugin for Jenkins
https://plugins.jenkins.io/amazon-ecs
MIT License
192 stars 226 forks source link

Ensure maxAgents is respected when requesting additional agents. #284

Closed tomcart90 closed 1 year ago

tomcart90 commented 1 year ago

This change aims to fix the issues reported on https://github.com/jenkinsci/amazon-ecs-plugin/issues/269. Essentially when requesting additional agents the excessWorkload value is passed regardless of the maxAgents limit. When triggering parallel jobs excessWorkload may in fact be higher than the number of available agents when maxAgents is set.

uorbe001 commented 1 year ago

Our ci is constantly triggering hundreds or thousands of excess agents (which is causing total collapse), while being limited to 10 agents and it seems to be for the same reason fixed here. Is there anything that can be done to help this get merged?

tomcart90 commented 1 year ago

Thanks for shepherding this through @Stericson!