jenkinsci / amazon-ecs-plugin

Amazon EC2 Container Service Plugin for Jenkins
https://plugins.jenkins.io/amazon-ecs
MIT License
192 stars 227 forks source link

Add Ulimits capability to aws task creation #310

Closed bachiri closed 1 year ago

bachiri commented 1 year ago

Description :

Add Ulimits Capability to the plugin to configure the desired Ulimit:

image

Github Issue:

https://github.com/jenkinsci/amazon-ecs-plugin/issues/257

How the changes were tested:

The plugin was tested in this Jenkins instance by building the .hpi file and also internally.

bachiri commented 1 year ago

Hi @Stericson if can you have a look at this PR. Thanks in advance.

Stericson commented 1 year ago

@bachiri Would you mind addressing the small items I noted? Following that, I'll get this merged.

bachiri commented 1 year ago

Thanks @Stericson feedbacks addressed.

bachiri commented 1 year ago

Thanks @Stericson for the quick feedback/reactivity, when should I expect a release containing this feature. And I think also since this pr is merged we can close this issue

Stericson commented 1 year ago

@bachiri I'll work to get it out in the next couple of weeks.

bachiri commented 1 year ago

@bachiri I'll work to get it out in the next couple of weeks.

Thanks @Stericson 🙏 Looking forward for the release to update our internal tooling and mitigate the issue we are currently facing.