jenkinsci / amazon-ecs-plugin

Amazon EC2 Container Service Plugin for Jenkins
https://plugins.jenkins.io/amazon-ecs
MIT License
192 stars 227 forks source link

use custom retry condition to log retries #324

Closed wuillaum closed 6 months ago

wuillaum commented 1 year ago

This work comes as a followup on my original PR to implement retries with exponential backoff https://github.com/jenkinsci/amazon-ecs-plugin/pull/193

This PR is a minor quality of life improvement for the ECS Plugin. All this PR does is add logging when there are retries to the AWS API. I have been using this at my employer with success, as it has helped us rule out various infrastructure hiccups and slowdowns on our Jenkins setup.

Other users of this plugin that run on the scale of many thousands of jobs a day may find this useful, as the retry logs can act as an indicator for why jobs are stuck in the queue for a few extra minutes (especially when experiencing rate-limiting by AWS).

Testing done

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue