Closed k3np closed 6 months ago
This is a pretty critical fix, thanks so much! Any chance of getting it merged and released soon?
Thanks!
@kp-autorola Thanks for the proposed fix ! It really affects the use of ecs managed jenkins-agents. One request - Is it possible for you to add reviewers to this pull request ?
@vishal-elimu I don't have access to assign reviewers.
Ok @kp-autorola - Thanks for the update !
Hi - @pgarbe @jequals5 @carlosrodf is it possible for someone to add reviewer(s) to this pull request ?
Anyone know How to "Request a pull request review" ?
The number of executors on ECS Agent is currently hardcoded to 1 even though the number of executors is configurable is the ECS Cloud settings. This fix sets the number of executors from the ECS Cloud settings.
Fixes #326
Testing done
// Print NumExecutors in ECS Agent jenkins.model.Jenkins.instance.nodes.each { node -> println "NumExecutors: " + node.getNumExecutors() } // NumExecutors: 4 // Result: [com.cloudbees.jenkins.plugins.amazonecs.ECSSlave[ecs-test-pjt74]]