Enabled CD

[vwagh-dev]

Testing done

Submitter checklist

• [ ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• [ ] Ensure that the pull request title represents the desired changelog entry
• [ ] Please describe what you did
• [ ] Link to relevant issues in GitHub or Jira
• [ ] Link to relevant pull requests, esp. upstream and downstream changes
• [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

[jtnord]

It would remove the ability to have a semantic version for this plugin which is useful as it is connected to the version of the bundled httpclient5 lib.

this is not the case - and this is retained in the PR - the revision is specifically still tied to the version of the library - everything else comes after as a qualifier so semver is retained, which is exactly the same as the current release versions.

The only difference should be that the versions x.y.z-a.b a would not restart at zero for each bump in z but this still adheres to semver.

for an example see the releases caffeine-api plugin

[strangelookingnerd]

Waiting for https://github.com/jenkins-infra/repository-permissions-updater/pull/3980 to be merged.

[jtnord]

It would remove the ability to have a semantic version for this plugin which is useful as it is connected to the version of the bundled httpclient5 lib.

this is not the case - and this is retained in the PR - the revision is specifically still tied to the version of the library - everything else comes after as a qualifier so semver is retained, which is exactly the same as the current release versions.

To avoid any confusion, loosing semver is not the case with how CD is implemented here, as it is following Versioning with wrapped components (optional) from the docs

if you are enabling / reviewing CD on other repos, you need to follow this path, otherwise you will get non semver versions for api plugins.

You can always check by running mvn validate -Dset.changelist -Dignore.dirt and seeing what version it creates.

[strangelookingnerd]

To avoid any confusion, loosing semver is not the case with how CD is implemented here, as it is following Versioning with wrapped components (optional) from the docs

if you are enabling / reviewing CD on other repos, you need to follow this path, otherwise you will get non semver versions for api plugins.

You can always check by running mvn validate -Dset.changelist -Dignore.dirt and seeing what version it creates.

Thanks for the clarification, it’s been a while since I looked at that topic. It indeed makes life easier for library plugins.