Open wiphi opened 1 month ago
Same issue as in a previous version (https://github.com/jenkinsci/apache-httpcomponents-client-5-api-plugin/issues/29#issuecomment-1829791803)
Again, I fear there is nothing we can do besides downgrading the plugin and wait for a fix in the docker-plugin, docker-java or httpclient5.
I’ll leave the issue open to update with new information and for others to see.
Also reported to the docker plugin as:
Is there an upstream ticket for this issue?
There is not an upstream ticket for this issue. I've not had the time to create the upstream ticket yet. It needs evaluation to understand the root of the failure. The last time there was a regression due to httpclient 5, I believe that it was related to packaging. I don't know the root cause of this regression.
I believe the issue is far more likely to be resolved in a timely fashion if an upstream ticket is created
I believe that we should either report an upstream ticket and push this process along with momentum, or revert the relevant upgrade in the Jenkins library plugin and block downloads of the problematic version from the Update Center. The status quo, wherein we do not take action upstream but continue to deliver the problematic release in the Update Center, results in pain for operators and end users.
I believe that we should either report an upstream ticket and push this process along with momentum, or revert the relevant upgrade in the Jenkins library plugin and block downloads of the problematic version from the Update Center.
Agreed. I'll look for time this week or early next week to investigate the issue deeply enough so that I can submit an upstream issue.
@MarkEWaite Is there a reason we continue to leave our users exposed to this issue one week after I brought it to your attention (as opposed to reverting the breaking change)? This puts our users in the unfortunate position of having broken software by default.
@MarkEWaite Is there a reason we continue to leave our users exposed to this issue one week after I brought it to your attention (as opposed to reverting the breaking change)? This puts our users in the unfortunate position of having broken software by default.
I've left our users exposed because I hoped to find a better path to a solution. The weekend didn't allow it.
I'll propose the revert of the httpclient 5 library upgrade and then will try later today to investigate more deeply. If a workaround is available that avoids reverting the library upgrade, that would be better than reverting the httpclient 5 library upgrade.
I'll propose the revert of the httpclient 5.4 library upgrade and then will try later today to investigate more deeply
The revert of httpclient 5.4 has been released as 5.4-124.v31e2987e48f4. The version is called 5.4-124.v31e2987e48f4 but contains httpclient 5.3.1
I hope to investigate more deeply tomorrow and create an upstream issue so that the httpclient 5.4 maintainers can investigate further.
I did some more investigation and found that the issue was likely introduced by https://github.com/apache/httpcomponents-client/pull/540 which results in big portions of https://github.com/docker-java/docker-java/blob/main/docker-java-transport-httpclient5/src/main/java/com/github/dockerjava/httpclient5/ApacheDockerHttpClientImpl.java to be relying on deprecated functionallity.
I'm still not entirely convinced we are facing a regression in HttpClient but will try creating a MRE that preferably does not require Docker. With that, raising and hopefully fixing the issue should be easier.
I have filed HTTPCLIENT-2348 upstream
Okay, that’s embarrassing for me - I was unable to reproduce the test failure on my machine and went in the wrong direction from there on. Thanks for your effort!
I have filed docker-java/docker-java#2363 to track this upgrade in docker-java
Jenkins and plugins versions report
Environment
```text Jenkins: 2.462.2 OS: Linux - 5.15.0-122-generic Java: 17.0.12 - Eclipse Adoptium (OpenJDK 64-Bit Server VM) --- ant:511.v0a_a_1a_334f41b_ antisamy-markup-formatter:162.v0e6ec0fcfcf6 apache-httpcomponents-client-4-api:4.5.14-208.v438351942757 apache-httpcomponents-client-5-api:5.4-118.v199115451c4d asm-api:9.7-33.v4d23ef79fcc8 authentication-tokens:1.119.v50285141b_7e1 bootstrap5-api:5.3.3-1 bouncycastle-api:2.30.1.78.1-248.ve27176eb_46cb_ branch-api:2.1178.v969d9eb_c728e build-timeout:1.33 build-token-root:151.va_e52fe3215fc caffeine-api:3.1.8-133.v17b_1ff2e0599 checks-api:2.2.1 cloud-stats:336.v788e4055508b_ cloudbees-folder:6.951.v5f91d88d76b_b_ command-launcher:115.vd8b_301cc15d0 commons-compress-api:1.26.1-2 commons-lang3-api:3.17.0-84.vb_b_938040b_078 commons-text-api:1.12.0-129.v99a_50df237f7 coverage:1.16.1 credentials:1378.v81ef4269d764 credentials-binding:681.vf91669a_32e45 dark-theme:479.v661b_1b_911c01 data-tables-api:2.1.6-1 declarative-pipeline-migration-assistant:1.6.4 declarative-pipeline-migration-assistant-api:1.6.4 delivery-pipeline-plugin:1.4.2 display-url-api:2.204.vf6fddd8a_8b_e9 docker-commons:443.v921729d5611d docker-java-api:3.4.0-94.v65ced49b_a_7d5 docker-plugin:1.6.2 docker-workflow:580.vc0c340686b_54 dtkit-api:3.0.2 durable-task:577.v2a_8a_4b_7c0247 echarts-api:5.5.1-1 eddsa-api:0.3.0-4.v84c6f0f4969e email-ext:1844.v3ea_a_b_842374a_ envinject:2.919.v009a_a_1067cd0 envinject-api:1.199.v3ce31253ed13 file-operations:266.v9d4e1eb_235b_a_ font-awesome-api:6.6.0-2 forensics-api:2.6.0 git:5.5.1 git-changelog:3.39 git-client:5.0.0 gitea:220.v4618c82a_40fb_ github:1.40.0 github-api:1.321-468.v6a_9f5f2d5a_7e github-branch-source:1797.v86fdb_4d57d43 gradle:2.13 gson-api:2.11.0-41.v019fcf6125dc handy-uri-templates-2-api:2.1.8-30.v7e777411b_148 htmlpublisher:1.36 ignore-committer-strategy:1.0.4 instance-identity:185.v303dc7c645f9 ionicons-api:74.v93d5eb_813d5f jackson2-api:2.17.0-379.v02de8ec9f64c jakarta-activation-api:2.1.3-1 jakarta-mail-api:2.1.3-1 javax-activation-api:1.2.0-7 javax-mail-api:1.6.2-10 jaxb:2.3.9-1 jdk-tool:80.v8a_dee33ed6f0 jjwt-api:0.11.5-112.ve82dfb_224b_a_d joda-time-api:2.13.0-85.vb_64d1c2921f1 jquery:1.12.4-1 jquery3-api:3.7.1-2 jsch:0.2.16-86.v42e010d9484b_ json-api:20240303-41.v94e11e6de726 json-path-api:2.9.0-58.v62e3e85b_a_655 junit:1300.v03d9d8a_cf1fb_ ldap:725.v3cb_b_711b_1a_ef mailer:472.vf7c289a_4b_420 mapdb-api:1.0.9-40.v58107308b_7a_7 matrix-auth:3.2.2 matrix-project:832.va_66e270d2946 mina-sshd-api-common:2.13.2-125.v200281b_61d59 mina-sshd-api-core:2.13.2-125.v200281b_61d59 okhttp-api:4.11.0-172.vda_da_1feeb_c6e pam-auth:1.11 parameterized-trigger:806.vf6fff3e28c3e pipeline-build-step:540.vb_e8849e1a_b_d8 pipeline-github-lib:61.v629f2cc41d83 pipeline-graph-analysis:216.vfd8b_ece330ca_ pipeline-groovy-lib:730.ve57b_34648c63 pipeline-input-step:495.ve9c153f6067b_ pipeline-milestone-step:119.vdfdc43fc3b_9a_ pipeline-model-api:2.2214.vb_b_34b_2ea_9b_83 pipeline-model-definition:2.2214.vb_b_34b_2ea_9b_83 pipeline-model-extensions:2.2214.vb_b_34b_2ea_9b_83 pipeline-rest-api:2.34 pipeline-stage-step:312.v8cd10304c27a_ pipeline-stage-tags-metadata:2.2214.vb_b_34b_2ea_9b_83 pipeline-stage-view:2.34 pipeline-utility-steps:2.17.0 plain-credentials:183.va_de8f1dd5a_2b_ plugin-util-api:5.1.0 postbuild-task:1.9 prism-api:1.29.0-17 publish-over:0.22 publish-over-cifs:0.16 publish-over-ssh:1.25 resource-disposer:0.23 scm-api:696.v778d637b_a_762 script-security:1362.v67dc1f0e1b_b_3 skip-certificate-check:1.1 snakeyaml-api:2.3-123.v13484c65210a_ ssh-credentials:343.v884f71d78167 ssh-slaves:2.973.v0fa_8c0dea_f9f sshd:3.330.vc866a_8389b_58 structs:338.v848422169819 subversion:1275.va_7b_014f3fc2c text-file-operations:1.3.2 theme-manager:262.vc57ee4a_eda_5d timestamper:1.27 token-macro:400.v35420b_922dcb_ trilead-api:2.147.vb_73cc728a_32e variables-replace-plugin:1.0.0 variant:60.v7290fc0eb_b_cd workflow-aggregator:600.vb_57cdd26fdd7 workflow-api:1336.vee415d95c521 workflow-basic-steps:1058.vcb_fc1e3a_21a_9 workflow-cps:3964.v0767b_4b_a_0b_fa_ workflow-durable-task-step:1371.vb_7cec8f3b_95e workflow-job:1436.vfa_244484591f workflow-multibranch:795.ve0cb_1f45ca_9a_ workflow-scm-step:427.v4ca_6512e7df1 workflow-step-api:678.v3ee58b_469476 workflow-support:926.v9f4f9b_b_98c19 ws-cleanup:0.46 xunit:3.1.5 ```What Operating System are you using (both controller, and any agents involved in the problem)?
Ubuntu LTS
Reproduction steps
unix:///var/run/docker.sock
Expected Results
Connection to local Docker API.
Actual Results
Anything else?
After downgrading to Version
apache-httpcomponents-client-5-api:5.3.1-117.v4d95117cd34f
its working again.Are you interested in contributing a fix?
No response