search

jenkinsci / artifact-promotion-plugin

A simple Jenkins plugin to promote artifacts.
29 stars 23 forks source link

Multimodule support for Nexus OSS #4

Open Timizki opened 9 years ago

Timizki commented 9 years ago

Hi,

I have added multimodule project promotion support for Nexus OSS. It will read from given pom.xml file projects modules and "moves" them to release repository.

BG, Timo Paananen

jenkinsadmin commented 9 years ago

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

hcguersoy commented 9 years ago

Hi Timo,

thank you providing this and sorry for my late answer, I was not notified :-(

I'll look into it and give you feedback as soon as I've the time (hope this week).

Kind regards Halil

hcguersoy commented 9 years ago

Hi Timo,

the build runs currently into a compiler error. Maybe the last commit was faulty?

Timizki commented 9 years ago

Hi Halil-Cem,

Sorry that this fix took so long, I have been sick and little pit too busy lately.

I did also add function that promotes javadoc and sources artifacts also if they are found in staging repository and added possibility turn of pom uploading.

When I added those functions I noticed that plugins code base was starting to get messy so I did quite large refactoring. Now it is lot nicer but will still need some work (some duplicate code etc.). There should be also more unit / integration tests, but I have to study how those are done for jenkins plugins.

Timizki commented 9 years ago

Damn wrong button, did not mean to close this :)

hcguersoy commented 9 years ago

Hi,

hope you get well soon.

BTW, can you pls rename you 'Promoter' so it is clear that it needs a Maven project?

Timizki commented 9 years ago

It seems that I failed to push correctly latest changes, I will repush in monday morning.

hcguersoy commented 9 years ago

Hi Timo,

any progress on this? I would like to integrate this functionality then your pr is ready to merge.