search

jenkinsci / audit2db-plugin

Jenkins plugin to record build audit information to database.
https://plugins.jenkins.io/audit2db/
5 stars 24 forks source link

Adapt icon path removal from core #27

Closed NotMyFault closed 2 years ago

NotMyFault commented 2 years ago

The change proposed prepares the plugin for the icon path removal from core in the upcoming LTS line. This change affects plugins not using the icon API or relying on paths. Plugins using the API properly in the first place are unaffected by this change.

Could you trigger a release after merging this PR please, giving people a chance to update the plugin before updating to the next LTS version @sergueik
Thanks in advance!

NotMyFault commented 2 years ago

Any chance you could take care of this PR and cut a release? The next LTS baseline selection is currently ongoing @sergueik

sergueik commented 2 years ago

Hello Alexander

The change in question looks somewhat cosmetic to me, unfortunately i am not sure i have working Jenkins environment to run and make sure the passing tests - i remember not all tests been successful after conversion to pipeline super classes. Do you have any Java code feature request that would justify diving into that project after it being stale for many years ?

Thanks

Serguei Kouzmine On Saturday, April 30, 2022, 07:18:52 AM EDT, Alexander Brandes @.***> wrote:

Any chance you could take care of this PR and cut a release? The next LTS baseline selection is currently ongoing @sergueik

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

NotMyFault commented 2 years ago

The change proposed makes sure your icons don't break on the next LTS baseline, because you aren't using the appropriate API but rely on path of the icon. Considering views in Jenkins are commonly done in Jelly and not in Java, this change affects the appropriate Jelly file and no Java file.

sergueik commented 2 years ago

thanks for the feedback Alexander

What i tried to say i can merge the change but i will not be able to run tests and have passed. I understand what templates and Jelly in particular , is :-)

Serguei Kouzmine

 On Saturday, April 30, 2022, 03:08:32 PM EDT, Alexander Brandes ***@***.***> wrote:

The change proposed makes sure your icons don't break on the next LTS baseline, because you aren't using the appropriate API but rely on path of the icon. Considering views in Jenkins are commonly done in Jelly and not in Java, this change affects the appropriate Jelly file and no Java file.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>