jenkinsci / aws-credentials-plugin

CloudBees Amazon Web Services Credentials Plugin
https://plugins.jenkins.io/aws-credentials/
MIT License
29 stars 75 forks source link

[JENKINS-67452] Do not add blank external ids #125

Closed jtnord closed 2 years ago

jtnord commented 2 years ago

Fixes #116

check the externalId is not blank or empty before adding it.

this covers the existing case where a credential was created before the externalId field was introduced (null) as well as after it was where it would be converted to an empty String (which is not a valid external id)