By doing so and running mvn -DskipTests verify, Spotbugs reported that com.cloudbees.jenkins.plugins.awscredentials.AWSCredentialsImpl was implementing the interface AmazonWebServicesCredentials, but so is BaseAmazonWebServicesCredentials, which AWSCredentialsImpl extends, so I removed that redundant interface declaration.
I checked that everything was still fine with mvn verify and everything looks good.
Let me know if I missed anything with this PR.
Thanks a lot for your review!
[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue
Hello folks :wave:
I'm currently following the Improve a Plugin documentation for Jenkins plugins modernization, and noticed we could add more spotbugs checks for this plugin.
By doing so and running
mvn -DskipTests verify
, Spotbugs reported thatcom.cloudbees.jenkins.plugins.awscredentials.AWSCredentialsImpl
was implementing the interfaceAmazonWebServicesCredentials
, but so isBaseAmazonWebServicesCredentials
, whichAWSCredentialsImpl
extends, so I removed that redundant interface declaration.I checked that everything was still fine with
mvn verify
and everything looks good.Let me know if I missed anything with this PR.
Thanks a lot for your review!