jenkinsci / aws-credentials-plugin

CloudBees Amazon Web Services Credentials Plugin
https://plugins.jenkins.io/aws-credentials/
MIT License
29 stars 75 forks source link

Increase spotbugs checks and fix redundant interface declaration #189

Closed aneveux closed 1 year ago

aneveux commented 1 year ago

Hello folks :wave:

I'm currently following the Improve a Plugin documentation for Jenkins plugins modernization, and noticed we could add more spotbugs checks for this plugin.

By doing so and running mvn -DskipTests verify, Spotbugs reported that com.cloudbees.jenkins.plugins.awscredentials.AWSCredentialsImpl was implementing the interface AmazonWebServicesCredentials, but so is BaseAmazonWebServicesCredentials, which AWSCredentialsImpl extends, so I removed that redundant interface declaration.

I checked that everything was still fine with mvn verify and everything looks good.

Let me know if I missed anything with this PR.

Thanks a lot for your review!

aneveux commented 1 year ago

Hello @jglick , @Vlatombe ,

Can I get a quick review on that one please? :heart: