search

jenkinsci / aws-sam-plugin

https://plugins.jenkins.io/aws-sam
MIT License
9 stars 14 forks source link

Fix region dropdown issue #11

Closed edreanernst closed 3 years ago

edreanernst commented 4 years ago

This fixes the issue that has been reported and verified where the settings dropdown for the AWS region does not populate.

The issue is documented in both #8 and #10.

This fix basically catches the exception when trying to enumerate an unsupported region, and logs it as an INFO message.

edreanernst commented 3 years ago

@modmac @mikedeck @seansummers You guys still maintaining this?

mikedeck commented 3 years ago

AWS is still maintaining this project but it was handed over to a different group internally.

I’ll forward this to the new maintainers to make sure they are aware.

-Mike

On Dec 23, 2020, at 3:53 AM, Edrean Ernst notifications@github.com wrote:



@modmachttps://github.com/modmac @mikedeckhttps://github.com/mikedeck @seansummershttps://github.com/seansummers You guys still maintaining this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/jenkinsci/aws-sam-plugin/pull/11#issuecomment-750054280, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AABJU4TIM6MU33W3RQMQV2TSWG4VLANCNFSM4M23BKPQ.

edreanernst commented 3 years ago

AWS is still maintaining this project but it was handed over to a different group internally.

I’ll forward this to the new maintainers to make sure they are aware.

-Mike

Thanks @mikedeck !!

gpreston-riot commented 3 years ago

I think we are experiencing this issue here on our Jenkins instance. Would love to bump this PR to get it merged and rolled out! :)

lesau commented 3 years ago

Thank you for submitting this pull request and refreshing this! As Mike has mentioned, this plugin has been recently handed over between the groups internally. We are reviewing the issues at the moment and will get back to you shortly.

Meanwhile, we are interested in learning more about your use-cases and bottlenecks because we are reviewing the next steps for this plugin. Please feel free to send a direct message to arrange a call @victorlesau.

Thanks, Victor

continuousintegrationaccount commented 3 years ago

Good to see that this issue is fixed. Please process this PR. Currently I'm running into this issue too. TIA

chandlersamuels commented 3 years ago

@mikedeck - Hey, any updates on when this PR will get merged in and rolled out? We are experiencing this issue here on our Jenkins instance as well. Thanks! :)