search

jenkinsci / aws-sam-plugin

https://plugins.jenkins.io/aws-sam
MIT License
9 stars 14 forks source link

Use Safe YAML instead of Snake YAML #38

Closed GavinZZ closed 10 months ago

GavinZZ commented 10 months ago
  1. SnakeYAML 2.2 are used by default in suggested Jenkins plugins and some of the default plugins instead. This caused an issue for customers who are using Jenkins since Jenkins only allows one version of an existing dependency. The version 2.2 requires a different code syntax. So for users who want to use aws-sam-plugin, it fails at reading the template step. Use SafeYAML instead.

Testing done

Local tests pass and CI passes.

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue