Support GithubApp Credentials

jenkinsci / aws-secrets-manager-credentials-provider-plugin

AWS Secrets Manager Credentials Provider for Jenkins

https://plugins.jenkins.io/aws-secrets-manager-credentials-provider/

MIT License

65 stars 43 forks source link

Support GithubApp Credentials #133

Open samuhepp opened 3 years ago

samuhepp commented 3 years ago

Dependencies

Support GithubApp credentials: https://github.com/jenkinsci/github-branch-source-plugin/blob/master/docs/github-app.adoc

Feature Request

I can't see a way to plug in Github App credentials. Could this be feasibly supported?

These credentials are used in jobs like multibranchPipelineJob.

chriskilding commented 3 years ago

There is already a PR for this: https://github.com/jenkinsci/aws-secrets-manager-credentials-provider-plugin/pull/87

trispad commented 2 years ago

I opened #186 to attempt to get the changes from #87 released. Any support is welcome.

richardj-bsquare commented 2 years ago

Really hoping this progresses. Need just this to codify my Jenkins deployment in terraform.

trispad commented 2 years ago

@richardj-bsquare Maybe not the cleanest, but I can tell you that #186 works for me. I built it independently and installed in in Jenkins and it is working for me.