Closed presPetkov closed 5 months ago
Thanks for your update. I'm augmenting your PR with a feature that lets people set the AWS ClientConfiguration
directly. This is so that they can use different proxy settings specifically for this plugin, if they don't want it to use the Jenkins system-wide proxy configuration. Will be pushing a couple more commits as I refine this
Let me know when you are finished and I will take the plugin from the build in the checks and run some tests. Thanks
@presPetkov alright, first draft complete.
The rough outline of how the feature will work now is:
proxy
is configured, the plugin will use that proxy config.proxy
configuration (if that is present). This allows people to use a different proxy config just for Secrets Manager, if they should need to.Give it a spin and let me know how it goes :)
Link to issue: https://github.com/jenkinsci/aws-secrets-manager-credentials-provider-plugin/issues/305
Jenkins url/manage/pluginManager/advanced gives the user the option to specify Http Proxy Configuration.
This configuration is not used by the aws-secrets-manager-credentials-provider-plugin.
With this pull request I propose that the plugin uses the proxy configuration if it is provided.
Testing done
Configuration
AWS credentials are not listed
The error in the logs
After installing the local build the AWS creds are listed
Testing with the proxy not set