search

jenkinsci / azure-artifact-manager-plugin

Jenkins Azure artifact manager plugin
https://plugins.jenkins.io/azure-artifact-manager/
MIT License
6 stars 10 forks source link

Add disable external url option #97

Closed WenjunMao closed 7 months ago

WenjunMao commented 7 months ago

Fixes #96 Add disable external url option. One option can disable Jenkins from generating SAS URLs when users want to view artifact files in a closed network.

Testing done

WenjunMao commented 7 months ago

If the external URL can be disabled, using a private endpoint would be a good option.

timja commented 7 months ago

If the external URL can be disabled, using a private endpoint would be a good option.

You don't need to disable the external URL then, if you setup the private endpoint and the DNS resolution, Azure will use its 'magic' DNS so that the public url will resolve a CNAME for the private endpoint and your users will hit the private endpoint NIC and not the public address

WenjunMao commented 7 months ago

If the external URL can be disabled, using a private endpoint would be a good option.

You don't need to disable the external URL then, if you setup the private endpoint and the DNS resolution, Azure will use its 'magic' DNS so that the public url will resolve a CNAME for the private endpoint and your users will hit the private endpoint NIC and not the public address

In my special network, it is very difficult to use that magic.