jenkinsci / azure-keyvault-plugin

Jenkins plugin for Azure Keyvault
https://plugins.jenkins.io/azure-keyvault/
MIT License
14 stars 21 forks source link

Add trailing slash if it doesn't exist #228

Closed bsloan-icl closed 10 months ago

bsloan-icl commented 10 months ago

This PR adds a trailing slash to the Key Vault URL if it does not already exist. This is to fix #227 where the passphrase for SSH keys wasn't being retrieved if the URL did not contain the trailing slash.

Fixes #227

Testing done

If the Key Vault URL is missing the trailing slash, the passphrase for the SSH key is still retrieved successfully and the SSH key is created in Jenkins. image

image

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue
timja commented 10 months ago

Thanks!