search

jenkinsci / azure-keyvault-plugin

Jenkins plugin for Azure Keyvault
https://plugins.jenkins.io/azure-keyvault/
MIT License
14 stars 21 forks source link

Add support for secret file credentials #246

Closed ysmaoui closed 5 months ago

ysmaoui commented 5 months ago

Adding support for credentials of type secret file

Testing done locally with secrets in an azure keyvault

image

image

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue
ysmaoui commented 5 months ago

solves partially https://github.com/jenkinsci/azure-keyvault-plugin/issues/181 I think ( but only UTF-8 encoded files, no support for base64 encoded files here -- this can be added in another PR maybe )

timja commented 5 months ago

Untested but looks sane