jenkinsci / azure-storage-plugin

21 stars 45 forks source link

Make CSP compatible and remove YUI #316

Closed timja closed 2 weeks ago

timja commented 2 weeks ago

Followed https://github.com/jenkinsci/credentials-plugin/blob/master/docs/consumer.adoc for cleaning up the credentials code

Followed https://www.jenkins.io/doc/developer/security/csp/ for CSP

YUI spreadsheet for yui adaption: https://docs.google.com/spreadsheets/d/1UjvtFmNmEdjMN5DUoFxJfBryA8q-E5_HwOzVKbVG9b0/edit?gid=0#gid=0

Cleaned up the UI while I was touching this code, looks like lots of dead cruft from a previous migration that wasn't cleaned up

Testing done

Manually clicked the button and the dialog still appears

Submitter checklist

basil commented 3 days ago

Thanks @timja! This fixed part of the problem, but there are still a few more CSP violations tracked in #322.