search

jenkinsci / azure-vm-agents-plugin

This repo is for azure vm agents plugin for jenkins. Azure devops CICD is the team which owns it for now
https://plugins.jenkins.io/azure-vm-agents/
43 stars 99 forks source link

AzureVMAgent template donot have attribute to set license_type #506

Closed Lathavrp closed 4 months ago

Lathavrp commented 7 months ago

What feature do you want to see added?

No attribute available to set license type as "windows_client/windows_server" for the agents launching with AzureSSHLauncher

Upstream changes

No response

Are you interested in contributing this feature?

No response

timja commented 7 months ago

Can you explain with more context or links? I don't know what this license type is.

Lathavrp commented 7 months ago

Sorry for the late response, could not respond due to family sickness

License type attribute not available to set value as “windows_client/windows_server” for the jenkins vm agents with AzureVMAgent plugin and AzureSSHLauncher(preInstallSsh) template Ref"azure-vm-agents-plugin/src/main/java/com/microsoft/azure/vmagent/AzureVMAgentTemplate.java at 638564a4422c6a53b28b18099357f7929f9b5f20 · jenkinsci/azure-vm-agents-plugin · GitHub

We are running jenkins in K8s cluster deployed as helm chart and JCACS configuration on Azure.

This attribute is available, while we are creating VM via terraform How to deploy Windows 11 on Azure - Azure Virtual Machines | Microsoft Learn

Lathavrp commented 7 months ago

Hello @timja any support here to add license_type attribute/field something like OsType or osDiskSize https://github.com/jenkinsci/azure-vm-agents-plugin/blob/638564a4422c6a53b28b18099357f7929f9b5f20/src/main/java/com/microsoft/azure/vmagent/AzureVMAgentTemplate.java#L1091