search

jenkinsci / badge-plugin

Jenkins Badge plugin
https://plugins.jenkins.io/badge/
MIT License
32 stars 43 forks source link

Enable spotless #142

Closed strangelookingnerd closed 6 months ago

strangelookingnerd commented 6 months ago

Enables spotless and apply formatting to sources.

Testing done

Ran mvn spotless:apply and verified changes.

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue
strangelookingnerd commented 6 months ago

@MarkEWaite Any idea why the spotless check runs locally but fails on ci.jenkins.io? Am I missing something?

MarkEWaite commented 6 months ago

@MarkEWaite Any idea why the spotless check runs locally but fails on ci.jenkins.io? Am I missing something?

Just a guess, but maybe your local line termination configuration is different than spotless expects? I ran mvn spotless:apply on my Linux machine and it changed the line termination on several of the files that had been formatted previously. Maybe you're on a platform or have a configuration that needs to be told that Unix line termination is preferred for this repo?