search

jenkinsci / bitbucket-branch-source-plugin

Bitbucket Branch Source Plugin
https://plugins.jenkins.io/cloudbees-bitbucket-branch-source
MIT License
216 stars 351 forks source link

Plugin needs a maintainer who actively uses bitbucket 🙏 #288

Closed jetersen closed 3 years ago

jetersen commented 4 years ago

This plugin needs a maintainer who actively uses bitbucket. https://jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/ https://plugins.jenkins.io/cloudbees-bitbucket-branch-source/ image

michallaskowski commented 4 years ago

Hi. I am actively using Bitbucket Server. And we are using the plugin in our multibranch pipeline jobs. I am not sure if I have enough time yet, what would be the scope? edit: ok, I see there are some issues with BitBucket 7.0, but we are still < 7.0. Not sure if I can help with that particular topic.

reitzmichnicht commented 4 years ago

Is it recommended to switch to the official bitbucket plugin? https://github.com/jenkinsci/atlassian-bitbucket-server-integration-plugin Whats the difference concerning features and stability?

michallaskowski commented 4 years ago

@Jetersen I think I can help now with BitBucket 7.0, but given there is a new plugin, would be great to know what would be the long term plan.

jetersen commented 4 years ago

The difference is that this plugin supports both Bitbucket Server and Bitbucket cloud. Long term plan is just to continue support the features already exist. If someone has some great ideas how to improve it further are more than welcome to drive the project forward.

@reitzmichnicht switching plugin is up to you and you alone, I cannot recommend either. I cannot even recommend Bitbucket nor Atlassian as I do not understand why they chose to create a new plugin instead of improving an existing plugin with a rather large install base.

Bitbucket Branch Source plugin (supports both cloud and server): https://plugins.jenkins.io/cloudbees-bitbucket-branch-source/ image

Bitbucket Server plugin (supports ONLY server): https://plugins.jenkins.io/atlassian-bitbucket-server-integration/ image

jetersen commented 4 years ago

Regarding scope, it is totally up to the maintainer to choose the scope. So 🤷‍♂

ryancurrah commented 4 years ago

I don't know a ton of Java. I could maintain it and try to automate some integration testing against different versions of Bitbucket. Does CloudBees not give you any funding for this project? It's like one of their customers most useful plugins.

OmriHarary commented 4 years ago

Just spitballing here, but if this plugin is lacking in a maintainer, and the official one is lacking in functionality, does it make sense to work towards merging the two?

jetersen commented 4 years ago

@OmriHarary I mentioned this in the mailing list when atlassian announced their plugin.

It seemed like they were very much against that idea, without any good reasoning.

https://groups.google.com/forum/#!searchin/jenkinsci-dev/bitbucket$20server|sort:date/jenkinsci-dev/3BTEJjqB-mo/p6Lb33SAAQAJ

Zauxst commented 4 years ago

Pardon to interject, but I didn't get that from their response, even more, I didn't get to see your proposition either.

Since they are looking to be part of the "recommended plugins" and are required to reach a popularity threshold which this plugin seems to pass with flying colors, it might be worth to specifically suggest that merging them. Or at least drag them here :) to be part of these discussions (on this github issue).

I can see both plugins being a thing on their own and in unison, as their plugin is working on a particular repository while this plugin has a multi-pipeline target, it might be worth it to everyone to suggest this... Or at least explain to them this functionality which most of us here, love it.

OmriHarary commented 4 years ago

I have to say that I agree with @Zauxst, I don't read that from their response nor do I see the proposition itself.

Whether or not it makes sense that they created yet another Bitbucket plugin for Jenkins when there are already so many, I think finding if there is a way to unite the two could ultimately lead to the best outcome, especially for the plugins' users.

jetersen commented 4 years ago

I might be reading in between the lines as a frustrated (previous user)/maintainer 😅 Again those that want to take over maintainership will have to take this chat with Atlassian... I have given up on anything Atlassian related.

jetersen commented 4 years ago

I'll point to this as my disappointment in Atlassian: https://jira.atlassian.com/browse/BCLOUD-5814

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mattiassluis commented 4 years ago

I proposed to Atlassian as well to support this plugin or look at integrating while dealing with Bitbucket Server 7 compatibility issues. I looked also at their plugin and the features back then and it looks like they take a different approach. I might be mistaken but from what I noticed it doesn't support:

With regards to maintainership, our team has the willingness to help but we lack the Java and Jenkins Plugin knowledge which I think is crucial to keep the quality level of this project when it comes to contributions or understand the contents of pull request changes at the required level. At the same time I guess at this point it is better to have a few less knowledgable maintainers than no maintainers at all?

jglick commented 4 years ago

I have heard a useful distinction be made, between pull request reviewers and approvers. A reviewer would look at the Files tab and point out low-level things that are not caught by current automation (CI, style apps): this comment is confusing, this API call is incorrect here, this variable reference could throw a NullPointerException. An approver would be someone who takes responsibility for releases and doing manual sanity tests where necessary, and would make overall comments on a PR: this UI choice is inconsistent, we are not yet ready to drop BB Server 4.x support, the added complexity in the code here is not justified by the trifling improvement, this is not perfect but it is a net gain so we should go ahead and merge it. If you cannot find anyone who can take on both roles, it is best to have some people in each role, and it is easier to find volunteers to help review while an approver needs to make a longer-term commitment.

bitwiseman commented 4 years ago

I have merge permissions on this plugin now. I would rather there be a community maintainer of this plugin - someone who can guide this plugin forward not just take some PRs. For now I'll go ahead and review and merge the existing PR/fixes and cut a release.

2improveIT commented 4 years ago

I am actively using this plugin with bitbucket server, and have already submitted some pull requests for this plugin. I am supporting my clients with this plugin, and have a deep knowledge of java, and this plugin (especially the bitbucket server part of it).

2improveIT commented 4 years ago

I am actively using this plugin with bitbucket server, and have already submitted some pull requests for this plugin. I am supporting my clients with this plugin, and have a deep knowledge of java, and this plugin (especially the bitbucket server part of it).

@jetersen how can I become a maintainer ?

jetersen commented 4 years ago

@2improveIT good place to start.

https://www.jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/

2improveIT commented 4 years ago

@2improveIT good place to start.

https://www.jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/

Thx, I just applied for it.

maulik-modi commented 3 years ago

hello @jetersen , Do we have any other contributor from Atlassian team ? Atlassian team is taking off Bitbucket server line up starting 01 Feb 2021 image

bitwiseman commented 3 years ago

@maulik-modi That seems like a question for a discussion and/or another issue.

Zauxst commented 3 years ago

Hi, who is in charge of merging PRs? There are multiple PRs opened that seem to improve the quality of the plugin overal.

Can we do anything to speed up the process?

bitwiseman commented 3 years ago

@Zauxst Would you like to become a maintainer on this plugin, taking responsibility ensuring PRs are well tested and do not break existing functionality?

2improveIT commented 3 years ago

Hi,

I also want to become a maintainer, like already asked before.

Kind regards,

Hein

Op 11 mei 2021 om 19:23 heeft Liam Newman @.***> het volgende geschreven:

 @Zauxst Would you like to become a maintainer on this plugin, taking responsibility ensuring PRs are well tested and do not break existing functionality?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

mguillem commented 3 years ago

Hi is there a maintainer here? According to the plugin page there are 8 maintainers for this project. Could one of them have a look at the opened pull requests?

Thanks Marc

lifeofguenter commented 3 years ago

Hi all 👋🏽 ,

I am going to close this issue for now. We have nine maintainers assigned to the project and it has been relatively active already.

I will be doing some cleanups and try my best to facilitate for the awesome work from all contributors and maintainers. If anyone wants to reach out, I will be trying to be active in our gitter chat :)