jenkinsci / bitbucket-branch-source-plugin

Bitbucket Branch Source Plugin
https://plugins.jenkins.io/cloudbees-bitbucket-branch-source
MIT License
216 stars 352 forks source link

Ignores Build strategies "Skip build trigger" #546

Closed stevewallone closed 2 years ago

stevewallone commented 2 years ago

Jenkins and plugins versions report

Environment ```text Jenkins: 2.319.1 OS: Linux - 5.4.0-1015-gkeop --- Parameterized-Remote-Trigger:3.1.5.1 ace-editor:1.1 active-directory:2.25 ansicolor:1.0.1 ant:1.13 antisamy-markup-formatter:2.6 apache-httpcomponents-client-4-api:4.5.13-1.0 artifactory:3.15.1 audit-trail:3.10 authentication-tokens:1.4 authorize-project:1.4.0 aws-credentials:1.33 aws-java-sdk:1.12.131-302.vbef9650c6521 aws-java-sdk-cloudformation:1.12.131-302.vbef9650c6521 aws-java-sdk-codebuild:1.12.131-302.vbef9650c6521 aws-java-sdk-ec2:1.12.131-302.vbef9650c6521 aws-java-sdk-ecr:1.12.131-302.vbef9650c6521 aws-java-sdk-ecs:1.12.131-302.vbef9650c6521 aws-java-sdk-elasticbeanstalk:1.12.131-302.vbef9650c6521 aws-java-sdk-iam:1.12.131-302.vbef9650c6521 aws-java-sdk-logs:1.12.131-302.vbef9650c6521 aws-java-sdk-minimal:1.12.131-302.vbef9650c6521 aws-java-sdk-ssm:1.12.131-302.vbef9650c6521 basic-branch-build-strategies:1.3.2 bitbucket:214.v2fd4234d0554 bitbucket-scm-trait-commit-skip:0.4.0 blueocean:1.25.2 blueocean-autofavorite:1.2.4 blueocean-bitbucket-pipeline:1.25.2 blueocean-commons:1.25.2 blueocean-config:1.25.2 blueocean-core-js:1.25.2 blueocean-dashboard:1.25.2 blueocean-display-url:2.4.1 blueocean-events:1.25.2 blueocean-git-pipeline:1.25.2 blueocean-github-pipeline:1.25.2 blueocean-i18n:1.25.2 blueocean-jira:1.25.2 blueocean-jwt:1.25.2 blueocean-personalization:1.25.2 blueocean-pipeline-api-impl:1.25.2 blueocean-pipeline-editor:1.25.2 blueocean-pipeline-scm-api:1.25.2 blueocean-rest:1.25.2 blueocean-rest-impl:1.25.2 blueocean-web:1.25.2 bootstrap4-api:4.6.0-3 bootstrap5-api:5.1.3-4 bouncycastle-api:2.25 branch-api:2.7.0 build-name-setter:2.2.0 build-timeout:1.20 build-token-root:1.9 build-token-trigger:1.0.0 build-user-vars-plugin:1.8 built-on-column:1.1 caffeine-api:2.9.2-29.v717aac953ff3 checks-api:1.7.2 cloud-stats:0.27 cloudbees-bitbucket-branch-source:734.v2f848c5e6ea2 (downgraded from 737.vdf9dc06105be) cloudbees-disk-usage-simple:0.10 cloudbees-folder:6.17 command-launcher:1.6 conditional-buildstep:1.4.1 config-file-provider:3.8.2 configuration-as-code:1.55 configuration-as-code-groovy:1.1 configuration-as-code-support:1.18 configurationslicing:1.52 copyartifact:1.46.2 countjobs-viewstabbar:1.0.1 credentials:1074.v60e6c29b_b_44b_ credentials-binding:1.27 cvs:2.19 dashboard-view:2.18 display-url-api:2.3.5 docker-build-publish:1.3.3 docker-commons:1.17 docker-workflow:1.26 durable-task:493.v195aefbb0ff2 echarts-api:5.2.2-2 email-ext:2.86 embeddable-build-status:2.0.3 envinject:2.4.0 envinject-api:1.8 extended-read-permission:3.2 external-monitor-job:1.7 favorite:2.3.3 font-awesome-api:5.15.4-5 ghprb:1.42.2 git:4.10.1 git-client:3.11.0 git-parameter:0.9.14 git-server:1.10 github:1.34.1 github-api:1.301-378.v9807bd746da5 github-branch-source:2.11.4 github-organization-folder:1.6 gitlab-plugin:1.5.27 google-chat-notification:1.4 google-oauth-plugin:1.0.6 gradle:1.38 greenballs:1.15.1 groovy:2.4 h2-api:1.4.199 handlebars:3.0.8 handy-uri-templates-2-api:2.1.8-1.0 hashicorp-vault-plugin:336.v182c0fbaaeb7 hipchat:2.2.1 htmlpublisher:1.28 http_request:1.13 ivy:2.1 jackson2-api:2.13.1-246.va8a9f3eaf46a javadoc:1.6 jaxb:2.3.0.1 jdk-tool:1.5 jenkins-design-language:1.25.2 jenkins-multijob-plugin:1.36 jersey2-api:2.35-3 jira:3.6 jjwt-api:0.11.2-9.c8b45b8bb173 job-dsl:1.78.3 job-import-plugin:3.4 jobConfigHistory:2.31-rc1098.b666422863b2 jquery:1.12.4-1 jquery-detached:1.2.1 jquery3-api:3.6.0-2 jsch:0.1.55.2 junit:1.53 kubernetes:1.31.2 kubernetes-cli:1.10.3 kubernetes-client-api:5.11.2-182.v0f1cf4c5904e kubernetes-credentials:0.9.0 ldap:2.7 lockable-resources:2.13 mailer:391.ve4a_38c1b_cf4b_ mapdb-api:1.0.9.0 marathon:1.6.0 mask-passwords:3.0 matrix-auth:3.0 matrix-project:1.19 maven-plugin:3.16 mercurial:2.16 metrics:4.0.2.8 momentjs:1.1.1 monitoring:1.90.0 nant:1.4.3 node-iterator-api:1.5.1 oauth-credentials:0.5 okhttp-api:4.9.3-105.vb96869f8ac3a pam-auth:1.6.1 parameterized-trigger:2.43 pipeline-build-step:2.15 pipeline-github-lib:1.0 pipeline-graph-analysis:188.v3a01e7973f2c pipeline-input-step:427.va6441fa17010 pipeline-maven:3.10.0 pipeline-milestone-step:1.3.2 pipeline-model-api:1.9.3 pipeline-model-declarative-agent:1.1.1 pipeline-model-definition:1.9.3 pipeline-model-extensions:1.9.3 pipeline-multibranch-defaults:2.1 pipeline-rest-api:2.20 pipeline-stage-step:291.vf0a8a7aeeb50 pipeline-stage-tags-metadata:1.9.3 pipeline-stage-view:2.20 pipeline-utility-steps:2.11.0 plain-credentials:1.7 plugin-util-api:2.12.0 popper-api:1.16.1-2 popper2-api:2.11.0-1 prometheus:2.0.10 publish-over:0.22 publish-over-ssh:1.22 pubsub-light:1.16 rebuild:1.33 resource-disposer:0.17 role-strategy:3.2.0 run-condition:1.5 s3:0.12.1 saferestart:0.3 saml:2.0.9 scm-api:595.vd5a_df5eb_0e39 script-security:1131.v8b_b_5eda_c328e scriptler:3.4 simple-theme-plugin:0.7 snakeyaml-api:1.29.1 sonar:2.14 sse-gateway:1.24 ssh:2.6.1 ssh-agent:1.23 ssh-credentials:1.19 ssh-slaves:1.33.0 ssh-steps:2.0.0 sshd:3.1.0 startup-trigger-plugin:2.9.3 stash-pullrequest-builder:1.17 stashNotifier:1.24 structs:308.v852b473a2b8c subversion:2.15.1 timestamper:1.16 token-macro:267.vcdaea6462991 translation:1.16 trilead-api:1.0.13 uno-choice:2.5.7 variant:1.4 windows-slaves:1.8 workflow-aggregator:2.6 workflow-api:1108.v57edf648f5d4 workflow-basic-steps:2.24 workflow-cps:2648.va9433432b33c workflow-cps-global-lib:552.vd9cc05b8a2e1 workflow-durable-task-step:1112.vda00e6febcc1 workflow-job:1145.v7f2433caa07f workflow-multibranch:706.vd43c65dec013 workflow-scm-step:2.13 workflow-step-api:622.vb_8e7c15b_c95a_ workflow-support:804.vba10a18a1476 ws-cleanup:0.40 ```

What Operating System are you using (both controller, and any agents involved in the problem)?

linux

Reproduction steps

  1. Add Build strategy->All Strategies Match->Skip build trigger if comment message contains->Pattern
  2. Create commit message containing the Pattern

Expected Results

The build trigger would be skipped.

Actual Results

The build triggered.

Anything else?

Downgrading to previous version fixed the issue. Also reported here - https://issues.jenkins.io/browse/JENKINS-67562?jql=resolution%20is%20EMPTY%20and%20component%3D21428

lifeofguenter commented 2 years ago

That version has been reverted, please refer to the latest release: https://plugins.jenkins.io/cloudbees-bitbucket-branch-source/