Add OAuth token to http clone link

jenkinsci / bitbucket-branch-source-plugin

Bitbucket Branch Source Plugin

https://plugins.jenkins.io/cloudbees-bitbucket-branch-source

MIT License

217 stars 349 forks source link

Add OAuth token to http clone link #810

Closed andrey-fomin closed 4 months ago

andrey-fomin commented 4 months ago

Problem was introduced in #796. Fixes #808.

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or in Jenkins JIRA
[x] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Did you provide a test-case? That demonstrates feature works or fixes the issue.

It's hard to write test for BitbucketOAuthAuthenticator because of statically called service methods.

andrey-fomin commented 4 months ago

Hi @rgrizzell I see the auth token is visible in the console output. Was it the case previously?

rgrizzell commented 4 months ago

Hi @rgrizzell I see the auth token is visible in the console output. Was it the case previously?

Yes, on version 866.vdea_7dcd3008e, the Auth Token is printed to console output. It looks something like: https://x-token-auth:{*****}@bitbucket.org/*****/*****.git

andrey-fomin commented 4 months ago

Hi @rgrizzell I see the auth token is visible in the console output. Was it the case previously?

Yes, on version 866.vdea_7dcd3008e, the Auth Token is printed to console output. It looks something like: https://x-token-auth:{*****}@bitbucket.org/*****/*****.git

Thanks. Then this fix should be ok.