Get fresh oauth token on every git clone

jenkinsci / bitbucket-branch-source-plugin

Bitbucket Branch Source Plugin

https://plugins.jenkins.io/cloudbees-bitbucket-branch-source

MIT License

217 stars 349 forks source link

Get fresh oauth token on every git clone #824

Closed andrey-fomin closed 3 months ago

andrey-fomin commented 3 months ago

Previously token was fetched only once and saved in BitbucketSCMSource.

Fixes #808. See also #810 and #796.

Your checklist for this pull request

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or in Jenkins JIRA
[x] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Did you provide a test-case? That demonstrates feature works or fixes the issue.

lifeofguenter commented 3 months ago

Awesome 🫶

ManneW commented 3 months ago

Might this be a fix for #816 as well, @andrey-fomin?

That issue (#816) do seem to be related to authentication and some kind of expiration of credentials/tokens, since it seems to be working as expected when forcefully doing Bitbucket interactions at regular intervals, but not otherwise.

andrey-fomin commented 3 months ago

@ManneW Looks like the #816 should also be fixed.

@giri-vsr please can you check?

ManneW commented 3 months ago

@andrey-fomin; Nice! :clap:

FYI @giri-vsr: I'll install the updated version and will remove the "periodic fetching" setting for one of our projects and see if it keeps working :crossed_fingers: :slightly_smiling_face:

giri-vsr commented 3 months ago

@andrey-fomin I have also removed "periodic fetching".I will confirm after a day.

giri-vsr commented 3 months ago

@andrey-fomin working fine after this fix.