jenkinsci / bitbucket-branch-source-plugin

Bitbucket Branch Source Plugin
https://plugins.jenkins.io/cloudbees-bitbucket-branch-source
MIT License
216 stars 353 forks source link

Add project key to cache key #837

Open thomas-boehm-tractive opened 6 months ago

thomas-boehm-tractive commented 6 months ago

If a requests is sent with a project key, and the key is not part of the cache key, following requests for other projects will result in the cached repositories for the first project, leading to wrong results

Your checklist for this pull request

Fixes #836

thomas-boehm-tractive commented 4 months ago

@KalleOlaviNiemitalo @lifeofguenter does anything speak against merging this PR? I think this is a very useful bugfix, as caching without the project key causes issues.

nfalco79 commented 3 months ago

@KalleOlaviNiemitalo any update on this?

nfalco79 commented 2 months ago

i hope that at least one of the current maintainer will take action on this PR @dwnusbaum @bitwiseman @car-roll This PR was already reviewed and stucks here from a very long time.

@lifeofguenter this is not a feature but a bug fix. Because cache feature was already in place. Using the BB project key in the organization folder configuration is ignore on project rescan causing on this folder to be populated with all repositories regardless in which project they are.